Template talk:SR Spell

Partial Revert

There were too many changes to document in the edit summary, so I'm documenting them here.

• Table format: the table format is deliberately fixed for consistency across pages. With the exception of the school, it should not change based on the presence or absence of parameters. (This change would also have left room for errors, allowing table rows to be varying numbers of cells if parameters were accidentally left out.)
• Blank vs. unspecified parameters: generally speaking, these should always be treated the same.
• Required parameters: they're required specifically to prevent people from making mistakes. Empty values should never be an option.
• One-off #local/#defines: generally speaking, it's more efficient not to specify variables for single uses, although I'll grant that readability will sometimes suffer a bit.
• Bold style: semicolons should never be used simply to bold an entire line (see Wikipedia:H:DL). While in this case, it would've rendered technically correct HTML, this probably doesn't actually qualify as a definition list, so it's best to avoid that style here. Of course, '''-style bolding should also be used inside a link instead of outside, so the template was previously wrong anyway.
• Skill check: unneeded, since the #locals will already be appropriately set if skill is not a valid value.
• End spacing: unneeded, since there's spacing at the beginning. Only matters for the end of the table, which needs to be on a new line anyway.

If there are any questions/concerns, please let me know. – Robin Hood  ^(talk) 20:38, 16 May 2018 (UTC)